[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Fwd: KFileDialog combined keyword/filename suggestion
From: Albert Astals Cid <aacid () kde ! org>
Date: 2009-03-08 23:52:42
Message-ID: 200903090052.43076.aacid () kde ! org
[Download RAW message or body]
A Dijous, 5 de març de 2009, Jonathan Marten va escriure:
> (Originally sent to kde-devel, suggested there that I copy to this list).
>
> Dear KFileDialog/KFileWidget experts,
>
> I've created a patch to allow both the "recent keyword" and the
> "suggested filename" to be specified to the static getSave* functions,
> which is the most useful scenario for an application. See previous
> message thread at http://lists.kde.org/?t=123565727900004&r=1&w=2.
>
> It compiles against current trunk and it seems to work in all cases
> (with both modified and unmodified applications) - but in such a
> fundamental part of KDE someone else should check it and say whether
> it's the right thing to do.
>
> The patch is attached to bug 186230
> (http://bugsfiles.kde.org/attachment.cgi?id=31800). Could someone
> please take a look? There are a copuple of typos in the API docs
> which someone has already spotted.
kDebug() needs to be removed or get the proper area (kfile_area)
New getStartUrl needs @since KDE 4.3
You need to provide proper API update for kfiledialog.h too (maybe it would be
a good idea just removing it from kfiledialog.h and put a link to kfilewidget
docu?)
Also it would be good if you could update kio/kfile/tests/kfiledialogtest.cpp
with some tests covering all the new cases.
Albert
>
> Regards and thanks,
> Jonathan
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic