[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KTabWidget / KTabBar changes for Qt 4.5
From:       David Faure <faure () kde ! org>
Date:       2009-03-02 23:50:42
Message-ID: 200903030050.43330.faure () kde ! org
[Download RAW message or body]

On Saturday 28 February 2009, Tomaz Canabrava wrote:
> Me thinks a better approach is to make it configurable.

The answer to _that_ is "is it really necessary?". We could make every 10 lines
of code configurable, but the configuration-option-explosion is what we
are trying to prevent.

> since it's hardcoded on Qt, we could use the patch that you just send
> to accept any mouse acelerator instead of just mmb or rmb. ( think of
> the left-handed ), or mouses with more than just 3 buttons. ( I have
> one with 7, almost all of them unusable on linux. )

Qt doesn't support those buttons. Discussing wish http://bugs.kde.org/48062 
isn't really that this thread is about.

Patch looks ok to me.

-- 
David Faure, faure@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]