[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KTabWidget / KTabBar changes for Qt 4.5
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2009-02-25 17:32:38
Message-ID: 20090225173238.GD4152 () neo ! apaku ! dnsalias ! org
[Download RAW message or body]

On 21.02.09 12:58:19, Urs Wolfer wrote:
> Please review the following patch.
> 
> Changes related to Qt 4.5 QTabWidget / QTabBar improvements:
> * Deprecate:
>   * KTabBar/KTabWidget#isTabReorderingEnabled; use QTabBar#setMovable
>   * KTabBar/KTabWidget#setCloseButtonEnabled; use QTabBar#setTabsClosable
>   * KTabBar/KTabWidget#setTabCloseActivatePrevious; use 
> QTabBar#setSelectionBehaviorOnRemove
>   * signal KTabBar#moveTab; port to QTabBar#setMovable and connect to 
> QTabBar#tabMoved
>   * signal KTabBar#closeRequest; connect to QTabBar#tabCloseRequested

This introduces a behavioural change apparently, because Qt uses
mouse-button1 to initiate tab-movements while KDE always used
middle-button.

I'm concerned about those that are accustomed to being able to drag around
tabs via middle-click. Should we re-add that for KTabWidget as backward
compatibility?

Andreas

-- 
You will contract a rare disease.
[prev in list] [next in list] [prev in thread] [next in thread]