[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kcmdlineargs input decoding
From:       Nick Shaforostoff <shaforostoff () gmail ! com>
Date:       2009-02-25 16:12:07
Message-ID: 758e8e2d0902250812r1af979d1xcec76054c1215647 () mail ! gmail ! com
[Download RAW message or body]

2009/2/25 Thiago Macieira <thiago@kde.org>:
> Em Quarta-feira 25 Fevereiro 2009, Ã s 16:07:06, Nick Shaforostoff escreveu:
>> Attached patch fixes the issue by delaying conversion and moving it to
>> KCmdLineArgs::arg(),
>> as a side affect it switches KCmdLineArgs args processing to use
>> QByteArray internaly,
>> which is a little bit more memory efficient.
>
> We've already added a workaround to make it work with QString, but that
> requires a patch not available for 4.5.0-rc1.
so what about my patch? i believe my patch isn't a workaround, but a
more cleaner solution.
should I commit it?

> In any case, yes, this will remain like that: you're not allowed to use
> QString::{from,to}Local8Bit() before QCoreApplication. The workaround is not
> meant to be used in other applications.

[prev in list] [next in list] [prev in thread] [next in thread]