On Wednesday 18 February 2009, Michael Pyne wrote:
> Standing by for comments (although it will be some hours before I'm online
> again most likely).

So far I have the outstanding request to call i18n() only once in the event of an error which I still need to change.

I've been working on KRun today (in kio) based on some discussion on IRC with dfaure as to where best to add the feature to make a file executable. My current work is attached as 2 patches. It compiles but is untested as I need to be awake in 6 hours for work.

First patch is against kdecore's KDesktopFile to make the isAuthorizedDesktopFile static method reflect the criteria used in my first patch against klauncher in addition to Kiosk (which means I will probably alter my first patch to simply call KDesktopFile::isAuthorizedDesktopFile), since this code is used by KRun and was already mostly identical. KDesktopFile::isAuthorizedDesktopFile used to always allow desktop files on the user's Desktop, which is what we're trying to avoid now.... ;)

The second patch (fix-desktop-file-security-2) adds the ability to make the file executable and continue automatically (if the reason execution was forbidden wasn't due to Kiosk, that is). I'm using a KMessageBox with a details button. I think the text is kind of clumsy but I'm very tired right now and can't think of anything better. :)

Again, I haven't been able to test yet, if someone does make a KRun testcase I'd appreciate screenshots so we can see what it look like, otherwise I will do so tomorrow when I get off of work and doing chores from my wife. ;)

Still missing is actually tying all of this into the file view used by Konq, Dolphin, and Folder View, which all still ends up in klauncher since I apparently have not covered all the possibilities in KRun. But I'd appreciate feedback on what I've got so far.

Regards,
- Michael Pyne