[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] KLockFile -- try harder
From:       David Faure <faure () kde ! org>
Date:       2009-02-20 0:35:31
Message-ID: 200902200135.32104.faure () kde ! org
[Download RAW message or body]

On Thursday 29 January 2009, Nick Shaforostoff wrote:
> > i think you forgot to add the autotests. :D
> Attached. All tests are passing.

Hmm, not here. klockfiletest fails everytime:
./klockfiletest.shell
********* Start testing of Test_KLockFile *********
Config: Using QTest library 4.5.0-rc1, Qt 4.5.0-rc1
PASS   : Test_KLockFile::initTestCase()
PASS   : Test_KLockFile::testLock()
PASS   : Test_KLockFile::testStale()
PASS   : Test_KLockFile::testUnlock()
FAIL!  : Test_KLockFile::testStaleNoBlockFlag() Compared values are not the same
   Actual (lockFile->lock(KLockFile::NoBlockFlag)): LockFail
   Expected (KLockFile::LockStale): LockStale
   Loc: [/d/kde/src/t/kdelibs/kdecore/tests/klockfiletest.cpp(115)]
PASS   : Test_KLockFile::cleanupTestCase()
Totals: 5 passed, 1 failed, 0 skipped
********* Finished testing of Test_KLockFile *********

Can you have a look? (or tell me what to debug, if it still works for you?)
Thanks.

-- 
David Faure, faure@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]