[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] implementation of a timezone backend for Windows
From:       Patrick Spendrin <patrick_spendrin () gmx ! de>
Date:       2009-02-12 23:14:38
Message-ID: 4994AD5E.5050407 () gmx ! de
[Download RAW message or body]

Till Adam schrieb:
> Folks,
> 
> as part of our work on Kontact on Windows in the enterprise4 branch 
> we've implemented a KTimeZone backend for Windows. You can find the 
> patch at:
> 
> http://kdab.net/~till/e4-patches/timezone-support-windows.diff
> 
> It's working ok, in e4, so we'd like to commit it to trunk, since it's 
> the only unmerged piece we have still. Didn't want to merge it before 
> 4.2 as we were not fully done with it yet. Patch applies fine to trunk. 
> David (Jarvie), please review, when you have time. Windows folk, maybe 
> you can also give it a read, in case we're doing something stupid, 
> Windows wise. Meanwhile I'll see about the unit tests on Windows etc., 
> not sure they all pass yet.
Looks ok so far.
maybe the test application could be removed from the comments and 
converted into a unittest instead.
> 
> Cheers,
> 
> Till
> 
regards,
Patrick

[prev in list] [next in list] [prev in thread] [next in thread]