From kde-core-devel  Mon Jan 05 18:11:19 2009
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Mon, 05 Jan 2009 18:11:19 +0000
To: kde-core-devel
Subject: Re: Squeezing "Show Keyboard Status" indicator into KDE 4.2
Message-Id: <200901051111.19975.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=123117912327834
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1501262.hI6JpkaEhA"

--nextPart1501262.hI6JpkaEhA
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 02 January 2009, Dotan Cohen wrote:
> Due to disability, I cannot move to KDE 4.x until this issue is resolved:
> http://bugs.kde.org/show_bug.cgi?id=3D165402
>
> I have spoken with the developer and he is confident that the applet
> is ready to move from review to plasma-addons, someone just needs to

i'm confident it isn't. ;)

first, the applet belong in kdebase/workspace imho. a11y isn't an "add on",=
 it=20
needs to be part of the core package.

unfortunately, the artwork is beyond shameful. i'd be emberassed to ship th=
at=20
thing in its current state. that's reason #1 it hasn't moved out of kderevi=
ew.

i understand that it needs to be clear and easy to see/perceive, but i thin=
k=20
we can do better than that.

there's also numerous fubar's in there, such as:

* it creates it's own KIconLoader on line 82

* it uses pixmaps in the icon theme for the buttons; this probably made sen=
se=20
when the code that was ported to make this applet was written. these days i=
t=20
should be using an SVG. this is one of the reasons it doesn't scale properl=
y,=20
which is ironic for an a11y tool.

* it doesn't use Plasma::Theme (see line 141)

etc... it needs work, but it just got moved into kdereview and nobody's rea=
lly=20
said anything about it to anyone since. whoever is working on it these days=
=20
ought to come into #plasma or find us on plasma-devel@kde.org and work thes=
e=20
issues out, otherwise we need to find someone who can do that work to preve=
nt=20
it from staying in kdereview or not making it into kdebase or plasma-addons=
 at=20
all.

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software


--nextPart1501262.hI6JpkaEhA
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkliTUcACgkQ1rcusafx20MKWgCgkY7VPc7XoaKPcBjjl+qbOyTe
1cEAn0Wpm9cIodMGPSzw97N55QVB7k2+
=is7j
-----END PGP SIGNATURE-----

--nextPart1501262.hI6JpkaEhA--