[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Kill ? icons
From:       Urs Wolfer <uwolfer () kde ! org>
Date:       2009-01-01 10:09:05
Message-ID: 200901011109.10261.uwolfer () kde ! org
[Download RAW message or body]


On Thursday 01 January 2009 00:56:54 Loïc Marteau wrote:
> On Mon, Dec 29, 2008 at 8:44 PM, Urs Wolfer <uwolfer@kde.org> wrote:
> > On Monday 29 December 2008 05:46:56 Loïc Marteau wrote:
> >> 4- For the notification plasmoid that dont have icon setted when the
> >> user copy or move a file I dont know where to search to resolve the
> >> problem
>
> I found the problem :
> The job notification come from a generic function in
> kuiserverjobtracker that automatically call the dbus stuff :
>
>     QDBusReply<QDBusObjectPath> reply =
> serverProxy->uiserver().requestView(componentData.aboutData()->programName(
>),
>
>      componentData.aboutData()->appName(),    <- used for setted the
> icon
>
>      job->capabilities());
>
> He take the componentData.aboutData()->appName() for choosing the
> icon, and this dont work with dolphin as "dolphin".png does not exist
> anywhere because the fd spec ask us to call this icon
> "system-file-manager".

What about using: 
!componentData.aboutData()->programIconName().isEmpty() ? 
componentData.aboutData()->programIconName() : componentData.aboutData()-
>programName()

>
> So the hackich way is to copy the system-file-manager icon to a
> dolphin one. I still dont have find how to do that (perhaps can
> someone point me the exact script that can do that) and i'm not sure
> that this is we really want to do.

Nope, please do not that. The script can be found here:
trunk/KDE/kdebase/runtime/pics/oxygen/icon-copy.sh

> Perhaps an other solution to set a correct icon instead of asking for
> the appname is to ask for the job title and have icons for such
> actions. Dont know if it is better for usability ?
> But reading the api from KJob im not sure that we can get the title
> action easily.
>
> About the fd spec im asking myself which "system-file-manager" icon
> kde should give when user set the default file browser application to
> konqueror. Perhaps the most proper solution to that is to really have
> a dolphin icon and a way to link the konqueror or the dolphin one,
> depending on the default file manager, for the system-file-manager
> icon. This will resolve our first issue too.
>
> >> 4bis- Sometimes this notifications are not really relevant when the
> >> user is directly responsible of the action and the action take no time
>
> This is solved now by adding a little delay to show the job in plasma

Hmm, it looks like I missed this mail.. Has it been sent to k-c-d?

> I have a last question about mimetype stuff.
>
> example :
> .srt is a registered mimetype and does not have proper icon. Should i
> copy the icon from plain text file as a workaround (stilll dont know
> how to do that) or is this some way to link the icon to this one ?

If it is a text file, yes. See above for script.

> Cheers and happy new good years ! You devs are my heroes and I really
> think that things like kde and open source software are something
> really important to make the world better !

Thank you! Of course also a happy new your to you!

Bye
urs

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]