[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE/kdelibs/kdeui/xmlgui
From:       "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date:       2008-12-31 11:03:53
Message-ID: 200812311203.54431.kossebau () kde ! org
[Download RAW message or body]

Am Dienstag, 30. Dezember 2008, um 22:41 Uhr, schrieb Urs Wolfer:
> SVN commit 903567 by uwolfer:
>
> Fix issue that many apps had two bookmark menus.
> BUG:173166
>
>  M  +2 -7      ui_standards.rc
>
>
> --- trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc #903566:903567
> @@ -1,5 +1,5 @@
>  <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
> -<kpartgui name="standard_containers" version="13">
> +<kpartgui name="standard_containers" version="14">
>  <MenuBar>
>    <Menu name="file"><text>&amp;File</text>
>      <Action name="file_new"/>
> @@ -133,12 +133,7 @@
>      <MergeLocal/>
>    </Menu>
>    <MergeLocal/>
> -  <Menu name="bookmarks"><text>&amp;Bookmarks</text>
> -    <Action name="bookmark_add"/>
> -    <Action name="bookmark_edit"/>
> -    <Separator/>
> -    <MergeLocal/>
> -  </Menu>
> +  <Action name="bookmarks"/>
>    <Menu name="tools"><text>&amp;Tools</text>
>      <Action name="tools_spelling"/>
>      <MergeLocal/>

Is this a backward compatibel change? I fear not. At least it breaks Okteta, 
which relies on this menu to be in the standard ui.rc, now has a <no text> 
entry there. And perhaps some more.
And is it okay to have a <Action /> entry on this level? Does it work at all? 
And at least konsole names that action "bookmark" (no trailing s). I suppose 
it is rather <MergeLocal/> which puts the menu from KBookmarkManager(?) 
there.

Sorry, no time to dig further today (guess why? ;)
But I think this should be solved differently. The menu entry should stay in 
the standard as it is. To standardize this menu. And KBookmarkManager needs 
to be fixed to obey to this standard. But more next year :)

"Guten Rutsch", everybody
(Happy Slide into the New Year! traditional wish in Germany, to have a good 
time on the change of the years)
Friedrich
-- 
Okteta - KDE 4 Hex Editor - http://utils.kde.org/projects/okteta
[prev in list] [next in list] [prev in thread] [next in thread]