[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: should KSaveFile::simpleBackupFile overwrite old backups?
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2008-12-25 0:34:40
Message-ID: 200812241734.45669.aseigo () kde ! org
[Download RAW message or body]
On Wednesday 24 December 2008, Allen Winter wrote:
> On Wednesday 24 December 2008 5:49:22 am Thiago Macieira wrote:
> > Robby Stephenson wrote:
> > >On Tuesday 23 December 2008, you wrote:
> > >> On Tuesday 23 December 2008 10:33:58 am Robby Stephenson wrote:
> > >> > What I've run into is that QFile::copy returns false if the file
> > >> > exists. So while I would have expected repeated calls to
> > >> > simpleBackupFile() to repeatedly copy the existing file to the
> > >> > backup, it actually fails if the backup already exists. Am I reading
> > >> > that right?
> > >>
> > >> I don't think this should be the intended behavior.
> > >> I think repeated simpleBackupFile() should just work, without having
> > >> to call QFile::remove() in between.
> > >
> > >Thanks. Bug 178640 filed.
> > >https://bugs.kde.org/show_bug.cgi?id=178640
> >
> > Can you just prepare a patch that does the necessary QFile::remove in the
> > simpleBackupFile function?
>
> Robby provided a patch and i committed it.
> 178640 is fixed now.
another bug bites the dust! ooh, and another's gone, another one bites the
dust!
Allen: just wanted to say "thanks" for the effort you're putting into making
sure these patches floating about on the list are getting attended to =)
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
["signature.asc" (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic