[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kdirwatch can not detect link change quite well
From:       Allen Winter <winter () kde ! org>
Date:       2008-12-19 14:45:02
Message-ID: 200812190945.02806.winter () kde ! org
[Download RAW message or body]

On Monday 24 November 2008 10:16:23 pm sycao wrote:
> Hi, all
>     I don't know where is best ML to post, so I post to both kde-devel
> and kde-core-devel.
> the problem comes up  when  I  traced the problem when using kcmshell4
> clock
> to set timezone, which is when you changed timezone second time,
> the setting just lost. Leo peng and I have tried to fix it, and I found
> the real problem is that
> KDirWatch loses watch on /etc/localtime ( in ktimezoned ).
>

Does anyone know whatever happened to this patch?
Did it get reviewed and/or committed?



>    I can reproduce the watch lose very easily:
>    # inotifywait -m /etc/localtime
>    # zic -l Asia/Shanghai
>    # zic -l Asia/Muscat
>    # touch /etc/localtime
>
> After Change timezone to Muscat, subsequent changes to /etc/localtime
> won't be watched. because KDirWatch use inotify, which monitoring file
> with respect to inode , not dir entry. zic relink ( hardlink )
> /etc/localtime, so inotify just tells attrib change ( st_nlink change )
> of the original file.
> I try hard to fix the problem and it works right now. please check it if
> there are any problems.
>
> the patches works both for 4.1.3 and trunk
>   best regards,
>     Siyuan Cao

[prev in list] [next in list] [prev in thread] [next in thread]