[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [Patch] Fix linking error in plasma workspace
From:       Martin Jansa <Martin.Jansa () mk ! cvut ! cz>
Date:       2008-12-19 10:00:27
Message-ID: 20081219100027.GA6354 () jama
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Hi,

while building kdebase/workspace/plasma/scriptengines I get lots of unresolved \
symbols from  ${QT_QTXML_LIBRARY} which are used in static library \
${QT_QTUITOOLS_LIBRARY}

This patch added ${QT_QTXML_LIBRARY} but its before QTUITOOLS
http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/scriptengines/qtscript/CMakeLists.txt?r1=872339&r2=888087


If its build with --as-needed and --no-undefined it fails with lots of
/usr/lib/qt4/libQtUiTools.a(ui4.o): In function
`QFormInternal::DomCustomWidgets::read(QDomElement const&)':
(.text+0x3c814): undefined reference to `QDomNode::firstChild() const'

I tried to remove --no-undefined from LD_FLAGS for this build but its
still there (maybe detected from QT LD_FLAGS or something).

There is patch which only moves ${QT_QTXML_LIBRARY} just AFTER
${QT_QTUITOOLS_LIBRARY}.

Please apply, issue is confirmed and patch reviewed by gentoo-devs..

Regards

-- 
uin:136542059                jid:JaMa@jabber.mk.cvut.cz
Jansa Martin                 sip:jamasip@voip.wengo.fr 
JaMa                         


["kdebase-workspace-plasma-4.1.85.QtXml.asNeeded.NoUndefined.patch" (text/plain)]

diff -uNr plasma-workspace-4.1.82/plasma/scriptengines/qtscript/CMakeLists.txt \
                plasma-workspace-4.1.82.new/plasma/scriptengines/qtscript/CMakeLists.txt
                
--- plasma-workspace-4.1.82/plasma/scriptengines/qtscript/CMakeLists.txt	2008-12-09 \
                12:20:32.000000000 +0100
+++ plasma-workspace-4.1.82.new/plasma/scriptengines/qtscript/CMakeLists.txt	2008-12-09 \
13:42:02.000000000 +0100 @@ -15,9 +15,9 @@
 target_link_libraries(plasma_scriptengine_qscript
                        ${KDE4_KDECORE_LIBS}
                        plasma
-                       ${QT_QTXML_LIBRARY}
                        ${QT_QTSCRIPT_LIBRARY}
                        ${QT_QTUITOOLS_LIBRARY}
+                       ${QT_QTXML_LIBRARY}
                        )
 
 install(TARGETS plasma_scriptengine_qscript
@@ -35,9 +35,9 @@
 target_link_libraries(plasma_runner_scriptengine_qscript
                        ${KDE4_KDECORE_LIBS}
                        plasma
-                       ${QT_QTXML_LIBRARY}
                        ${QT_QTSCRIPT_LIBRARY}
                        ${QT_QTUITOOLS_LIBRARY}
+                       ${QT_QTXML_LIBRARY}
                        )
 
 install(TARGETS plasma_runner_scriptengine_qscript


[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]