[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    kcmodule and kcmoduleproxy
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2008-12-04 2:00:19
Message-ID: 200812040300.19988.mail () dipe ! org
[Download RAW message or body]

Hi *

The KCMultiDialog class used for e.g. "Configure Konqueror" uses kcmodule for 
its configurable items and kcmoduleproxy which allows to delay loading the 
kcmodule plugins till they are requested.

Current situation is, that the kcmodule's are just always loaded and not only 
if they are needed/displayed. That results here in a delay of around 10 
seconds if I call "Configure Konqueror" till the dialog is displayed and does 
render the kcmoduleproxy's unneeded. The reason for that is, that on 
addPage() also KCModuleProxy::minimumSizeHint() got called and there the 
kcmodule is loaded.

Attached patch does fix that. Ok to commit?

Index: kcmoduleproxy.cpp
===================================================================
--- kcmoduleproxy.cpp   (revision 892245)
+++ kcmoduleproxy.cpp   (working copy)
@@ -343,7 +343,6 @@

 QSize KCModuleProxy::minimumSizeHint() const
 {
-       realModule();
        return QWidget::minimumSizeHint();
 }
[prev in list] [next in list] [prev in thread] [next in thread]