[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: include the svn revision in the --version info (wish 162179)
From:       David Faure <faure () kde ! org>
Date:       2008-12-02 10:28:49
Message-ID: 200812021128.49901.faure () kde ! org
[Download RAW message or body]

On Friday 21 November 2008, Alexander Neundorf wrote:
> This only runs if cmake runs. I.e. you can get a lot of updates via svn up but 
> as long as no cmake file is changed this doesn't run again, so you will have 
> a wrong svn revision.
> I wouldn't put it in as it is now.

But as it is now it would recompile everything that includes kdeversion.h
when cmake runs (which is already often enough), while if this is updated
whenever svn up is done, then after _every single update_ we'll have to
recompile everything that includes kdeversion.h? That's deadly.
I'm against this, it would kill productivity.

-- 
David Faure, faure@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]