[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: qt-copy patch for QDesktopServices to allow path kcm to work
From:       "Dan Meltzer" <parallelgrapefruit () gmail ! com>
Date:       2008-12-01 20:53:13
Message-ID: 46059ce10812011253h1194995ag13aa1716795b4e28 () mail ! gmail ! com
[Download RAW message or body]

On Mon, Dec 1, 2008 at 4:45 PM, Anne-Marie Mahfouf
<annemarie.mahfouf@free.fr> wrote:
> Hi,
>
> I have a small qt-copy patch attached: it allows QDesktopServices to take
> care of the expanded var and thus it makes the kcm About Me -> Paths work
> correctly.
> KConfigGroup writes to the xdg config file and then KGlobalSettings uses
> QDesktopServices to read from this file when needed. But QDesktopServices
> falls back to default each time it encounters a line with [$e] in it and
> this small patch fixes it.
>
> Is it OK to add it? All other ways to fix this bug would add more code and I
> don't see a reasonable way anyway ;)

I'm not the worlds greatest expert on regular expressions.. but why do
you make the addition a group? wouldn't it be better to do
("^XDG_(.*)_DIR.*=(.*)$")) and that way it is not necessary to change
the line further on.
>
> Anne-Marie
>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]