[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fixing KWidgetItemDelegate::focusedIndex()
From:       Aurélien Gâteau <aurelien.gateau () free ! fr>
Date:       2008-10-17 6:30:30
Message-ID: 48F83106.2020507 () free ! fr
[Download RAW message or body]

Rafael Fernández López wrote:
> Hi,
> 
>> Attached patches use an alternative approach: instead of tracking
>> the focused index, I just let KWidgetItemDelegate::focusedIndex()
>> figure out which one is focused when it's called. It's much simpler and
>> seems to work well. Is it ok for you?
> 
> Yes, it seems fine. I wonder why I let the switch() survive on the 
> "this-switch-is-no-longer-useful" patch...

Not your mistake: The only other case: of the switch() was removed by my 
first patch. I decided to do the clean in a separate patch to make the 
first one easier to review.

> Please commit.

OK. Will do.

Aurélien

[prev in list] [next in list] [prev in thread] [next in thread]