[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Slows starting of downloading with KIO
From:       David Faure <faure () kde ! org>
Date:       2008-10-14 9:19:34
Message-ID: 200810141119.35648.faure () kde ! org
[Download RAW message or body]

On Monday 02 January 2006, Michael Brade wrote:
> On Monday 02 January 2006 11:22, David Faure wrote:
> > On Sunday 01 January 2006 21:17, Michael Brade wrote:
> > > About the naming, it should be consistent: we have
> > > KDirLister::findByURL() and findByName() already. So call all static
> > > methods querying the global items item(s)*() and all methods operating on
> > > the files the KDirLister holds find*()? Suggestions?
> >
> > Oh, I see; tricky.
> >
> > I think the static methods should be cachedItemForURL and
> > cachedItemsForDir, that way it's clear that the caller might get nothing in
> > return, when the directory hasn't been listed yet, or has been removed from
> > the cache for any reason. Otherwise I foresee people assuming that
> > KDirLister::itemForURL()/itemsForDir() will take care of everything
> Ok, sounds good. Will add that stuff.

Just to follow up 2 years later: I added cachedItemForUrl now ;-)
(but didn't use it yet for copying, only for deleting, in order to fix the data loss bug 109181)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]