[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: External SVN item in
From:       Sebastian =?utf-8?q?Tr=C3=BCg?= <strueg () mandriva ! com>
Date:       2008-09-18 8:10:25
Message-ID: 200809181010.25414.strueg () mandriva ! com
[Download RAW message or body]

On Thursday 18 September 2008 01:16:43 Aaron J. Seigo wrote:
> On Wednesday 17 September 2008, Thiago Macieira wrote:
> > Can we please find a solution without svn:externals?
> >
> > This is duplicating code. Move it to a library.
>
> it is a library, it's just in workspace when it should be in either kdelibs
> or runtime.
>
> there's another similar issue in
> workspace/libs/nepomukqueryclient/interfaces which is duplicating dbus xml
> files
>
> my suggestion on the commit list for that one was this:
>
> * set a variable in workspace/CMakeLists.txt:
>
> if(CMAKE_SOURCE_DIR STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
>     set(WORKSPACE_STANDALONE 1)
> endif(CMAKE_SOURCE_DIR STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
>
> * check for that variable in nepomukqueryclient/CMakeLists.txt and either
> reference the xml files directly in runtime if kdebase is built as a whole
> or reference the xml files in the installation directory if workspace is
> built as a separate library
>
> can anyone see any downsides to that?
>
> if not, i think i'll end up moving all this stuff around this week if Trueg
> doesn't get to it.

I tried your solution. It worked here but failed on the dashboard.
So I now did a copy.
I will also copy all the lib classes for now. 
I thought it would be better to keep it out of kdelibs for now as it might 
still change. But then again, there is time to polish until 4.2, right?
Anyway, I will copy the classes for now and think of a better solution in a 
week when I am back.

Cheers,
Sebastian
[prev in list] [next in list] [prev in thread] [next in thread]