[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] Re: Help, Ok, Cancel KStandardGuiItems
From:       Allen Winter <winter () kde ! org>
Date:       2008-08-29 22:20:02
Message-ID: 200808291820.02813.winter () kde ! org
[Download RAW message or body]

On Friday 29 August 2008 16:25:30 Allen Winter wrote:
> Howdy,
> 
> I noticed that the Help ,Ok and Cancel buttons in KDialogs
> don't have tooltips or whatsthis. (Help has a tooltip, but no whatsthis).
> 
> This is due to those settings missing in KStandardGuiItems::ok(), et.al.
> 
> Is there a good reason for this?  Should I add the tooltips/whatthis
> to the KStandardGuiItems? Or not? Or maybe add them into
> the KDialog class directly?
> 
Attached is a patch for review that makes sure Help, Ok and Cancel
have tooltips and whatsthis.  Let me know if I can commit.
Or if you have better text.

-Allen

["kstandardguiitem.cpp.patch" (text/x-patch)]

Index: kstandardguiitem.cpp
===================================================================
--- kstandardguiitem.cpp	(revision 854384)
+++ kstandardguiitem.cpp	(working copy)
@@ -102,13 +102,17 @@ QString standardItem( StandardItem ui_en
 
 KGuiItem ok()
 {
-  return KGuiItem( i18n( "&OK" ), "dialog-ok" );
+  return KGuiItem( i18n( "&OK" ), "dialog-ok", i18n( "Apply changes and close" ),
+                   i18n( "When clicking <b>Ok</b>, the settings will be handed "
+                         "over to the program and the dialog will be closed." ) );
 }
 
 
 KGuiItem cancel()
 {
-  return KGuiItem( i18n( "&Cancel" ), "dialog-cancel" );
+  return KGuiItem( i18n( "&Cancel" ), "dialog-cancel", i18n( "Cancel changes and close" ),
+                   i18n( "When clicking <b>Cancel</b>, the settings will be "
+                         "discarded and the dialog will be closed." ) );
 }
 
 KGuiItem yes()
@@ -172,7 +176,10 @@ KGuiItem clear()
 KGuiItem help()
 {
   return KGuiItem( i18nc( "show help", "&Help" ), "help-contents",
-                   i18n( "Show help" ) );
+                   i18n( "Show help" ),
+                   i18n( "When clicking <b>Help</b>, a separate KHelpCenter "
+                         "window will open that provides more information "
+                         "about the settings." ) );
 }
 
 KGuiItem close()


[prev in list] [next in list] [prev in thread] [next in thread]