From kde-core-devel  Fri Aug 01 10:03:57 2008
From: Alex Merry <huntedhacker () tiscali ! co ! uk>
Date: Fri, 01 Aug 2008 10:03:57 +0000
To: kde-core-devel
Subject: Re: A more hands on review process
Message-Id: <200808011104.02461.huntedhacker () tiscali ! co ! uk>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=121758521102181
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1278835.fjeFt8xsg2"

--nextPart1278835.fjeFt8xsg2
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Thursday 31 July 2008 19:29:54 Stephen Kelly wrote:
> [snip] This could make the review process shorter,
> at the expense of the developer putting in more effort to document the
> app/lib.

In my personal opinion, this is no bad thing...

In general, +1 from me, but:

> Style
> * Coding style in consistent with the rest of the library / application
> * Variable names are consistent with the target module or library module.
> (m or m_ prefix, camel casing, descriptive variable names instead of a, b
> and c2 etc)
> * There are no excessively large methods. Methods longer than 40 lines can
> be broken into multiple methods if possible.
> * There are no excessively long lines. for lines greater than 80 characte=
rs
> it might be possible to use intermediate variables more.

I think this is where you're going to get issues.  If the target module has=
 a=20
coding style (eg: kdelibs or kdepim), then the application or library shoul=
d=20
conform to it, sure.  But I don't see why (and I suspect neither will autho=
rs=20
of code put in to kdereview) they should follow a coding style just because=
 a=20
lot of others in the same module use it.

Note that most of the code going into kdereview is not going to form part o=
f=20
an application or library (since such additions usually have their own revi=
ew=20
processes), but be an application or library in itself.

I can see that if the reviewed code is, say, a plugin for kopete or a data=
=20
engine or applet for plasma due for inclusion into kdebase, for example, yo=
u=20
might want to follow the coding style of that application, but I think it=20
should be down to the maintainers of the application as to whether to enfor=
ce=20
that.

Alex


=2D-=20
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org


--nextPart1278835.fjeFt8xsg2
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEUEABECAAYFAkiS340ACgkQBRauKLutZ9AI8ACYpP/OZhx7jUO5ykmZY6ghSqdg
LwCbBue7khET5LFF81iL4glPnHrW9YA=
=aSbk
-----END PGP SIGNATURE-----

--nextPart1278835.fjeFt8xsg2--