[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KFileDialog overwrite confirmation
From:       Rafael =?iso-8859-15?q?Fern=E1ndez_L=F3pez?= <ereslibre () kde ! org>
Date:       2008-07-30 9:29:56
Message-ID: 200807301129.59007.ereslibre () kde ! org
[Download RAW message or body]


Hi,

> I've modified the patch according to some suggestions given by (IRC)
> pinotree, ereslibre, winterz.
> Is it OK to commit now?

Add a small comment on kabstractfilewidget.h for adding the method as virtual 
for KDE 5, something like:

// KDE5 TODO: make virtual

Note the comment of type "//" so doxygen doesn't parse it.

The patch looks good. Please commit and thank you very much for this work.


Regards,
Rafael Fernández López.

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]