[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE/kdelibs/kdeui/icons
From:       Dirk Mueller <mueller () kde ! org>
Date:       2008-07-28 10:09:03
Message-ID: 200807281209.03609.mueller () kde ! org
[Download RAW message or body]

On Sunday 27 July 2008, Rafael Fernández López wrote:

> Lets disable again svg rendering. Icons that contain filters (such as
> blurring...) will not be correctly drawn. Qt implements Tiny SVG spec, not
> the full SVG spec (read comment on the code). For this reason, there is no
> hope for now, and we just can wait.

can we please have a bigger discussion about this other than via svn commits? 
which icons are drawin incorrectly? are they rendered so badly that they're 
unacceptable? Can icons be redesigned to workaround that issue?

This patch breaks support for other non-KDE icon themes that are released as 
SVG only (or rely on SVG support). Reenabling this ultra-hack over and over 
again avoids this issue getting fixed any time soon, and it credits badly over 
KDE because we do not support the freedom of the user to be able to choose 
another icon theme than the one that we consider the default.

If the general problem is oxygen specific then we should restrict the hack to 
oxygen, or if we need one particular feature (you mention blur filter), then 
implementing this particular filter should be doable for Qt, even though it 
only wants to support Tiny. 

There is an important difference between not wanting to support the full 
specification and supporting Tiny+selected things that are needed to make our 
life easier. 

So, unless there is a more concrete list of things that are broken appearing 
anywhere (or could somebody point me to the place where that is listed?), I'm 
going to revert that commit again in today+2 weeks. 

Greetings,
Dirk

> --- trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp #838292:838293
> @@ -57,13 +57,12 @@
>  #include <assert.h>
>  #include <kconfiggroup.h>
>
> -// The following define exists because the Qt SVG renderer needs
> -// to be improved. This will be removed soon. (ereslibre)
> -#ifdef QT_VERSION >= 0x040400
> -#define KDE_QT_SVG_RENDERER_FIXED
> -#else
> +// Qt implements Tiny SVG specification. This specification does not cover
> important elements +// that are pretty globally used on our icons, like
> blurring (and other filters). TT seems to have +// no interest in
> supporting the full SVG specification (it would be slower, even with JS,
> CSS +// support...). So, we have no chance for now. Let's disable svg
> rendering unconditionally. +// (ereslibre)
>  #undef KDE_QT_SVG_RENDERER_FIXED
> -#endif
>
>  //#define NO_LAZYLOAD_ICONTHEME


[prev in list] [next in list] [prev in thread] [next in thread]