[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Make KDiskFreeSpace more convenient -> KJob-like usage
From:       Sebastian =?iso-8859-15?q?Tr=FCg?= <strueg () mandriva ! com>
Date:       2008-07-24 7:07:22
Message-ID: 200807240907.23012.strueg () mandriva ! com
[Download RAW message or body]

On Wednesday 23 July 2008 22:14:00 Alex Merry wrote:
> On Wednesday 23 July 2008 15:56:29 Sebastian Trüg wrote:
> > On Wednesday 23 July 2008 15:35:52 Dirk Mueller wrote:
> > > On Wednesday 23 July 2008, Sebastian Trüg wrote:
> > > > please find attached a patch for KDiskFreeSpace. I found it to be
> > > > very inconvenient to use.
> > >
> > > A reminescense of the old implementation, which was async. I've changed
> > > it to be synchronous, so I'm not sure if we should invest more in that
> > > old interface. IMHO a static ::getFreeDiskspace() (better method name
> > > welcome) would be enough.
> >
> > Sure, for KDE 5, but for now we have to keep the old API.
>
> That just means you have to keep it around.  You could introduce the static
> method, and mark the old usage as deprecated.

That is what I just wrote to David. So having a method like

bool KIO::freeDiskSpace( const QString& path, KIO::filesize_t* avail, 
KIO::filesize_t* size = 0 )

would that be OK? And if so, should I revert the previous patch?

Cheers,
Sebastian


[prev in list] [next in list] [prev in thread] [next in thread]