[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Help with making stuff compile on non-Linux
From:       Alex Merry <huntedhacker () tiscali ! co ! uk>
Date:       2008-07-23 20:10:21
Message-ID: 200807232110.21252.huntedhacker () tiscali ! co ! uk
[Download RAW message or body]

On Wednesday 23 July 2008 09:15:06 Sebastian Trüg wrote:
> Please find attached a version containing some ifdefs. Do you think I can
> commit this or should I wait for Monday in case it breaks for some people
> and needs fixing by the real experts. ;)

I don't really see why you need to bother with the HAVE_* macros - why not 
just use #ifdef SCHED_BATCH and #ifdef SYS_ioprio_set directly?

IMO, this make the code more readable, because it's immediately obvious what 
the #ifdefs guard against.  The HAVE_* macros are really for CMake checks.

Alex



-- 
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org


[prev in list] [next in list] [prev in thread] [next in thread]