[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] 3d look for kwin alt-tab window selector aka tabbox
From:       Alexander Dymo <dymo () ukrpost ! ua>
Date:       2008-07-19 21:23:57
Message-ID: 200807200023.57849.dymo () ukrpost ! ua
[Download RAW message or body]

Hi,
I'd like to propose to add some 3d-ness to the default alt-tab window selector 
(tabbox) in kwin. The reason is that the tabbox is indistinguishable visually 
from the topmost window if the window has white background (see "before" 
screenshot). 

And I noticed that almost all apps I use - kdevelop, dolphin, kmail and 
firefox have white backgrounds which make it hard to see the alt-tab selector.

Admitteddly, with desktop effects enabled and window shadow it's a bit better, 
but only a bit (at least for me, - I don't distinguish colors that well).

What would you say about some 3d shape to the window? Please see the patch and 
"after" screenshot attached.


["kwin_3d_tabbox.patch" (text/x-patch)]

Index: workspace/kwin/tabbox.cpp
===================================================================
--- workspace/kwin/tabbox.cpp	(revision 833830)
+++ workspace/kwin/tabbox.cpp	(working copy)
@@ -61,11 +61,11 @@
     , display_refcount( 0 )
     {
     setFrameStyle(QFrame::StyledPanel);
-    setFrameShadow(QFrame::Plain);
+    setFrameShadow(QFrame::Raised);
     setBackgroundRole(QPalette::Base);
-    setLineWidth(2);
-    setMidLineWidth(2);
-    setContentsMargins( 2, 2, 2, 2 );
+    setLineWidth(3);
+    setMidLineWidth(3);
+    setContentsMargins( 3, 3, 3, 3 );
 
     showMiniIcon = false;
 

["window_selector_after.png" (image/png)]
["window_selector_before.png" (image/png)]

[prev in list] [next in list] [prev in thread] [next in thread]