[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Fwd: KDirOperator patchlets
From:       Daniel Molkentin <daniel () molkentin ! de>
Date:       2008-07-20 14:15:32
Message-ID: 200807201615.34788.daniel () molkentin ! de
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Heya,

somehow Carstens mail didn't make it through. Thus sending it on his behalf.

Cheers,
  Daniel

----------  Weitergeleitete Nachricht  ----------

Subject: Fwd: KDirOperator patchlets
Date: Sonntag, 20. Juli 2008
From: Carsten Pfeiffer <pfeiffer@kde.org>
To: danimo@kde.org

Hiya,

since I got a few friendly complaints that KuickShow doesn't work with KDE4, 
it seems I need to revive it a little.

Firtst thing I noticed (after getting it to compile at all) was that 
KDirOperator doesn't send out the fileHighlighted() signal e.g. when changing 
the current item. It only does that in multi-selection mode or when no 
selection is set at all. See attached kdiroperator-fileHighlighted.patch.

The second thing is that pressing return on the current item does not emit 
fileSelected() but fileHighlighted(). I'm wondering if this was an accident 
or done on purpose. See attached kdiroperator-fileSelected.patch.

I already committed the former patch to HEAD. Ideally, I'd like to see both in 
4.1.

Thanks for any comments,
Carsten

-- 
Carsten Pfeiffer

-------------------------------------------------------

-- 
Be part of something amazing, visit
http://www.kde.org/announcements/4.0/

["kdiroperator-fileHighlighted.patch" (text/x-diff)]

Index: kdiroperator.cpp
===================================================================
--- kdiroperator.cpp	(Revision 834402)
+++ kdiroperator.cpp	(Arbeitskopie)
@@ -2118,6 +2118,10 @@ void KDirOperator::Private::_k_slotSelec
         KFileItem nullItem;
         parent->highlightFile(nullItem);
     }
+    else {
+        KFileItem selectedItem = parent->selectedItems().first();
+        parent->highlightFile(selectedItem);
+    }
 }
 
 void KDirOperator::Private::_k_openContextMenu(const QPoint& pos)

["kdiroperator-fileSelected.patch" (text/x-diff)]

Index: kdiroperator.cpp
===================================================================
--- kdiroperator.cpp	(Revision 834618)
+++ kdiroperator.cpp	(Arbeitskopie)
@@ -2080,7 +2080,7 @@ void KDirOperator::Private::_k_slotActiv
     if (selectDir) {
         parent->selectDir(item);
     } else {
-        parent->highlightFile(item);
+        parent->selectFile(item);
     }
 }
 

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]