--nextPart2253671.h8nkC56Lmk
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Michael Leupold wrote:
>+    QDBusMessage replyMessage =3D
> walletLauncher->getInterface().connection().call(=20
> +        openMessage,=20
> QDBus::Block, 18000000);
>+    if (replyMessage.type() =3D=3D QDBusMessage::ReplyMessage) {
>+        QDBusReply<int> r(replyMessage);
>+        if (r.isValid()) {
>+            int drc =3D r;
>+            if (drc !=3D -1) {
>+                return new Wallet(drc, name);
>+            }
>         }

Patch seems fine.

On the section above, though, I have a suggestion for improvement. Instead=
=20
of:

    QDBusMessage replyMessage =3D....
    if (replyMessage.type() =3D=3D QDBusMessage::ReplyMessage) {
        QDBusReply<int> r(replyMessage);

You can simply do:
    QDBusReply<int> r =3D ....

where .... is still the same=20
(walletLauncher()->getInterface()->connection().call(...))

QDBusReply::isValid already includes the testing to see if the message is=20
a reply.

=2D-=20
=A0 Thiago Macieira =A0- =A0thiago (AT) macieira.info - thiago (AT) kde.org
=A0 =A0 PGP/GPG: 0x6EF45358; fingerprint:
=A0 =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358

--nextPart2253671.h8nkC56Lmk
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQBIdLuYM/XwBW70U1gRAgpfAJ9RoX8fCDsflmaWIzK7b1+K76HLZQCfds0v
+QC+s8J9PJD7aqBO6y2BspI=
=PzB5
-----END PGP SIGNATURE-----

--nextPart2253671.h8nkC56Lmk--