[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] kwalletd timeouts
From:       David Faure <faure () kde ! org>
Date:       2008-07-09 10:02:36
Message-ID: 200807091202.37151.faure () kde ! org
[Download RAW message or body]

On Wednesday 09 July 2008, Michael Leupold wrote:
> Am Dienstag, 8. Juli 2008 schrieben Sie:
> > > >Thus I propose the patch I attached which changes the (client)
> > > > [...]
> > > I propose changing both client and server behaviour.
> > > The call to open the wallet is sent and replied to immediately,
> > > indicating success in starting the opening. However, kwalletd notifies
> > > the caller of an open wallet via signal, which the client must listen to.
> > I agree that this is a lot cleaner. I'll give it a shot but having quite
> > some stuff to do right now I don't know when I could fit it in. When's the
> > deadline for getting this into 4.1 (the release schedules mentions tagging
> > of rc1 tonight and "Only urgent fixes, such as those things fixing
> > compilation errors") ?
> 
> So I just "nearly" got done but stumbled upon some issues and the fact that it 
> just won't be ready for RC1. As including it after seems highly unsafe 
> because the period that remains for testing is too short I think just pushing 
> the timeouts a little (25s -> 5h) will at least give the bug less exposure.
> 
> Please review the patch so I can possibly still commit it before RC1 is being 
> tagged.

I'm in favour of this patch going in. For real review I hope Thiago can have a quick look though.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]