From kde-core-devel Tue Jul 08 02:13:13 2008 From: Thiago Macieira Date: Tue, 08 Jul 2008 02:13:13 +0000 To: kde-core-devel Subject: Re: [PATCH] DNS cache for Konqueror/KIO Message-Id: <200807072313.19451.thiago () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=121548328522306 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1658174.oYMFh2D4Xu" --nextPart1658174.oYMFh2D4Xu Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline David Faure wrote: >On Monday 07 July 2008, Thiago Macieira wrote: >> Roland Harnau wrote: >> >According to [1] =A0the addreses returned by =A0getaddrinfo() (glibc >> >version) =A0are ordered: >> >"The important thing to remember here is that the addresses are >> >returned in an order where the first returned address has the highest >> >probability to succeed." >> > >> >[1] =A0http://people.redhat.com/drepper/userapi-ipv6.html >> >> That is true, but the DNS server also does a round-robin ordering of >> addresses to spread the load on identical servers. getaddrinfo() is >> kind-of smart, but it can't tell the difference between two global IP >> addresses of the same version (v4 or v6). >> >> Anyways, since the cache is held per application, this is not a big >> problem -- or a problem at all. >> >> Patch is good, perfectly indented, very clever. Please commit! > >Yes but not right now, less than 24 hours before RC1, right? >Or are you 100% sure that this is safe for all users? >Otherwise, as good as this is, it sounds more like KDE-4.2 material to > me... Yeah, better hold until unfreeze. It's not that critical, even if it lets=20 many people use KDE apps with broken routers. It can be applied to 4.2.0 and 4.1.1. =2D-=20 =A0 Thiago Macieira =A0- =A0thiago (AT) macieira.info - thiago (AT) kde.org =A0 =A0 PGP/GPG: 0x6EF45358; fingerprint: =A0 =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358 --nextPart1658174.oYMFh2D4Xu Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iD8DBQBIcs05M/XwBW70U1gRAgUiAJ401f4UYI5xYliMrxUeVC9fKM46KgCgiPO7 P2RO6S+RongqebMrd8ploy8= =Vk/W -----END PGP SIGNATURE----- --nextPart1658174.oYMFh2D4Xu--