From kde-core-devel Mon Jul 07 22:59:17 2008 From: David Faure Date: Mon, 07 Jul 2008 22:59:17 +0000 To: kde-core-devel Subject: Re: [PATCH] DNS cache for Konqueror/KIO Message-Id: <200807080059.18478.faure () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=121547161009350 On Monday 07 July 2008, Thiago Macieira wrote: > Roland Harnau wrote: > >According to [1]  the addreses returned by  getaddrinfo() (glibc > >version)  are ordered: > >"The important thing to remember here is that the addresses are > >returned in an order where the first returned address has the highest > >probability to succeed." > > > >[1]  http://people.redhat.com/drepper/userapi-ipv6.html > > That is true, but the DNS server also does a round-robin ordering of > addresses to spread the load on identical servers. getaddrinfo() is > kind-of smart, but it can't tell the difference between two global IP > addresses of the same version (v4 or v6). > > Anyways, since the cache is held per application, this is not a big > problem -- or a problem at all. > > Patch is good, perfectly indented, very clever. Please commit! Yes but not right now, less than 24 hours before RC1, right? Or are you 100% sure that this is safe for all users? Otherwise, as good as this is, it sounds more like KDE-4.2 material to me... -- David Faure, faure@kde.org, sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).