[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Text in tabs being cut off
From:       Thiago Macieira <thiago () kde ! org>
Date:       2008-07-07 12:54:05
Message-ID: 200807070954.05469.thiago () kde ! org
[Download RAW message or body]


Allen Winter wrote:
>On Monday 07 July 2008 08:23:08 Thiago Macieira wrote:
>> Michael Leupold wrote:
>> >Am Montag, 7. Juli 2008 schrieb Benjamin Meyer:
>> >> > a while ago I wrote a small patch to fix a bug causing some
>> >> > characters (like 'A' or 'y') being cut off in a tabbar. The bug
>> >> > is already on the TT
>> >> > task tracker but I figured it might be nice to have this fix in
>> >> > qt- copy.
>> >>
>> >> But either it is a bit moot anyway as I have reviewed the patch
>> >> (task 216537) and applied it to Qt main.
>> >
>> >Awesome, thanks!
>>
>> By "Qt main", Ben meant that he applied it for the Qt version that
>> will become Qt 4.5.0. It will not be present in 4.4.1 or later 4.4.x
>> versions.
>
>Then I propose putting a patch into qt-copy.

I won't interfere, but bear this in mind: each patch added to qt-copy is 
another source of breakage that Qt developers did not foresee. It may 
introduce problems somewhere else. It being good for Qt 4.5 doesn't mean 
it's good for 4.4.

We want to improve that, though. We have a few tricks up our sleeve and 
one of the ideas proposed was to let people run our testsuite, which 
would help people writing patches to verify that they haven't broken 
anything.

Until then, for KDE's stability sake, please be careful with qt-copy 
patches.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]