[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Text in tabs being cut off
From:       Michael Leupold <lemma () confuego ! org>
Date:       2008-07-05 13:08:23
Message-ID: 200807051508.23165.lemma () confuego ! org
[Download RAW message or body]

Hi there,

a while ago I wrote a small patch to fix a bug causing some characters 
(like 'A' or 'y') being cut off in a tabbar. The bug is already on the TT 
task tracker but I figured it might be nice to have this fix in qt-copy.

Do you think it's ok to commit?

Regards,
Michael

["0236-fix-qt-qtabbar-size.diff" (text/x-diff)]

qt-bugs@ issue : N216195
Trolltech task ID : 216537
bugs.kde.org number : 162737
applied: no
author: Michael Leupold <lemma@confuego.org>

This patch fixes some characters in a tabbar being cut-off due
to a wrong size hint (visible if using a kstyle).

--- src/gui/widgets/qtabbar.cpp	(Revision 820510)
+++ src/gui/widgets/qtabbar.cpp	(Arbeitskopie)
@@ -1084,7 +1084,7 @@
         QStyleOptionTabV2 opt;
         initStyleOption(&opt, index);
         opt.text = d->tabList.at(index).text;
-        QSize iconSize = tab->icon.isNull() ? QSize() : opt.iconSize;
+        QSize iconSize = tab->icon.isNull() ? QSize(0, 0) : opt.iconSize;
         int hframe  = style()->pixelMetric(QStyle::PM_TabBarTabHSpace, &opt, this);
         int vframe  = style()->pixelMetric(QStyle::PM_TabBarTabVSpace, &opt, this);
         const QFontMetrics fm = fontMetrics();


[prev in list] [next in list] [prev in thread] [next in thread]