[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Nepomuk file watch service moved to kdereview
From:       Allen Winter <winter () kde ! org>
Date:       2008-07-01 22:38:35
Message-ID: 200807011838.36260.winter () kde ! org
[Download RAW message or body]

On Tuesday 01 July 2008 13:13:45 Sebastian Trüg wrote:
> as there were no objections I moved the Nepomuk file watch service into 
> kdereview. You can find it in the nepomuk/filewatch subdirectory. Please have 
> a look so we can get it into KDE 4.1.
> 
> As discussed in the previous thread I removed the inotify dependancy due to 
> its immature status. Thus, the file watch service now solely depends on 
> KDirNotify. While this only captures KDE-only users, it is a way better 
> situation then having nothing at all.
> 
> Thanks for considering.
> 
First overall review looks good, but I especially like this code:
         regexpPath.replace( QRegExp( "([\\.\\?\\*\\\\+\\(\\)\\\\\\|\\[\\]{}])" ), "\\\\\\1" );

:)



[prev in list] [next in list] [prev in thread] [next in thread]