[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] re-implement void
From:       David Faure <faure () kde ! org>
Date:       2008-06-04 8:20:17
Message-ID: 200806041020.17796.faure () kde ! org
[Download RAW message or body]

On Saturday 31 May 2008, Michael O'Shea wrote:
> People,
> 
> I submitted a first draft of this a few weeks ago. David Faure made a few
> suggestions which I carried out.
> 
> Here's a new version of the patch.
> 
> Its purpose is to re-implement void DirectoryListThread::run() (found in
> kurlcompletion.cpp) using Qt calls.

Looks OK, but
1) you reverted some getenv->qgetenv changes, please undo that
2) you probably want to comment out the verbose kDebug calls before committing 

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]