[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [patch] kio job: send CMD_CLOSE before disconnecting the slave
From:       Jarosław Staniek <js () iidea ! pl>
Date:       2008-05-28 15:55:04
Message-ID: 483D8058.30600 () iidea ! pl
[Download RAW message or body]

for review:
explicitely send CMD_CLOSE before disconnecting the slave, fixes possible 
crashes e.g. in kdepim

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)

["job.patch" (text/plain)]

Index: kio/kio/job.cpp
===================================================================
--- kio/kio/job.cpp	(wersja 813711)
+++ kio/kio/job.cpp	(kopia robocza)
@@ -458,6 +458,7 @@
 {
     Q_Q(SimpleJob);
     if (!m_slave) return;
+    if (m_command == CMD_OPEN) m_slave->send(CMD_CLOSE);
     q->disconnect(m_slave); // Remove all signals between slave and job
     Scheduler::jobFinished( q, m_slave );
     m_slave = 0;


[prev in list] [next in list] [prev in thread] [next in thread]