[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] ported kurlcompletion.cpp!DirectoryListThread::run() to
From:       David Faure <faure () kde ! org>
Date:       2008-05-07 15:53:49
Message-ID: 200805071753.50485.faure () kde ! org
[Download RAW message or body]

On Friday 02 May 2008, Michael O'Shea wrote:
> If I'm right, the only thing that will vary is how quickly the dropdown list
> in Dolphin (in the case I'm interested in) fills up.

Well, that and other uses of completion, yes. The speed with which the GUI reacts
is exactly what users perceive as "performance", so it shouldn't be made slow :)

> currentDir.entryInfoList() seems costly for large directories, maybe
> > QDirIterator is better?
> >
> 
> I don't mind giving it a try but would you agree that the asynchronous mode
> of operation in kurlcompletion.cpp makes the distinction not so important ?

Well, entryInfoList also allocates much more memory... an extremely large directory
could make your machine swap -- that's unrelated to sync vs async...

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]