[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KIO fixes in kdelibs and kdebase
From:       David Faure <faure () kde ! org>
Date:       2008-05-07 10:29:37
Message-ID: 200805071229.38214.faure () kde ! org
[Download RAW message or body]

On Wednesday 07 May 2008, Vlad wrote:
> respect_copyjob_permissions.diff:
> - Fix KIO::file_move to respect its permissions parameter instead of
> just ignoring it. KIO::file_copy already respects the user-specified
> permissions.

The chmod should only be done if d->m_permissions is not -1.
The patches look fine otherwise, as far as I'm concerned.

A unit test for this change (in tests/jobtest.cpp) would be excellent :)

> kdelibs_largefile.diff:
> - Compile kdelibs with -D_LARGE_FILES instead of
> -D_LARGEFILE64_SOURCE, and drop the redundant -D_LARGEFILE64_SOURCE
> flag in kio.

I think you meant compile with -D_LARGEFILE64_SOURCE instead of -D_LARGE_FILES :)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]