[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    dialog
From:       Thomas Zander <zander () kde ! org>
Date:       2008-05-05 11:20:17
Message-ID: 200805051320.17434.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


I have this code in KOffice

    int res = KMessageBox::warningYesNoCancel( 0L, i18n( "<p>The document 
<b>'%1'</b> has been modified.</p><p>Do you want to save it?</p>", name ) );

Which generates the attached dialog.
Note how the last line is actually missing, you have to scroll down to see it.
This effectively means that most users will be answering a question that 
actually was not on screen. (we know many don't read these, how many do you 
estimate use the slider then?)

I'm not sure why this design is in kde, but I think its flawed, we should 
never have a slider in such a dialog and I'd like to ask kde-core-devel to 
reconsider this behavioral change.

Thanks.

ps. please cc answers as I'm not subscribed.
-- 
Thomas Zander

["unreadable-dialog.png" (image/png)]
["kmessagebox.diff" (text/x-diff)]

Index: dialogs/kmessagebox.cpp
===================================================================
--- dialogs/kmessagebox.cpp	(revision 803205)
+++ dialogs/kmessagebox.cpp	(working copy)
@@ -195,16 +195,8 @@
         messageLabel->setWordWrap(true);
     }
 
-    QScrollArea* messageScrollArea = new QScrollArea(mainWidget);
-    messageScrollArea->setWidget(messageLabel);
-    messageScrollArea->setFrameShape(QFrame::NoFrame);
-    messageScrollArea->setWidgetResizable(true);
-    QPalette scrollPal(messageScrollArea->palette());
-    scrollPal.setColor(QPalette::Window, Qt::transparent);
-    messageScrollArea->setPalette(scrollPal);
+    hLayout->addWidget(messageLabel);
 
-    hLayout->addWidget(messageScrollArea);
-
     QListWidget *listWidget = 0;
     if (!strlist.isEmpty()) {
         // enable automatic wrapping since the listwidget has already a good initial width

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]