From kde-core-devel  Fri Apr 11 08:38:31 2008
From: David Faure <faure () kde ! org>
Date: Fri, 11 Apr 2008 08:38:31 +0000
To: kde-core-devel
Subject: Re: [patch] KToolInvocation: re-enable Windows code, share with UNIX,
Message-Id: <200804111038.32229.faure () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=120790315601678

On Thursday 03 April 2008, Ralf Habacker wrote:
> David Faure schrieb:
> > On Tuesday 01 April 2008, Ralf Habacker wrote:
> >   
> >> I can answer these question by myself: invokeTerminal already use such a 
> >> configuration switch
> >>
> >>     KConfigGroup confGroup( KGlobal::config(), "General" );
> >>     QString exec = confGroup.readPathEntry("TerminalApplication", 
> >> "konsole");
> >>
> >> for invokeBrowser I suggest to define a 'UseInternalBrowser' flag, for 
> >> invokeMailer a 'UseInternalMailer' flag
> >>
> >>     
> >
> > There is already a configuration switch for the browser, please don't add a new one...
> > krun.cpp:      d->m_externalBrowser = KConfigGroup(KGlobal::config(), "General").readEntry("BrowserApplication");
> >
> >   
> Thanks for this pointer.
> 
> <probably little issue found>
> Searching a while in that direction let me found that this configuration
> options seems to be located in kfmclientrc too
> 
> kdebase\apps\konqueror\client\kfmclient.cpp
>         KConfig config(QLatin1String("kfmclientrc"));
>         KConfigGroup generalGroup(&config, "General");
>         if (!generalGroup.readEntry("BrowserApplication").isEmpty())
> 
> Should this not be located in kdeglobals too ? If so I would fix this.
> </probably little issue found>

KConfig config("kfmclientrc") also reads kdeglobals -- that's a feature of KConfig,
which makes the stuff in kdeglobals available in all KDE applications.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).