[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] KMainWindow::saveMainWindowSettings not saving toolbar in
From:       David Faure <faure () kde ! org>
Date:       2008-04-08 8:10:34
Message-ID: 200804081010.35317.faure () kde ! org
[Download RAW message or body]

On Tuesday 08 April 2008, Eduardo Robles Elvira wrote:
> Hello!
> 
> I've found a quite trivial to fix bug in KMainWindow. The problem is that even 
> thought saveMainWindowSettings() takes a KConfigGroup as an argument, it 
> saves the toolbar settings in new top-level config groups instead of saving 
> them in subgroups of the given config group. The patch is attached and it's 
> quite trivial (I changed just two lines).

This code didn't mean to use subgroups, subgroups didn't exist in kde3.
So this is not a bug, it's by design.
What is the reason to change it to subgroups? It would "look nicer", but it would
also break existing user settings from kde-4.0.x.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]