From kde-core-devel  Wed Apr 02 10:34:40 2008
From: David Faure <faure () kde ! org>
Date: Wed, 02 Apr 2008 10:34:40 +0000
To: kde-core-devel
Subject: Re: [patch] KToolInvocation: re-enable Windows code, share with UNIX,
Message-Id: <200804021234.41329.faure () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=120716451000971

On Tuesday 01 April 2008, Ralf Habacker wrote:
> I can answer these question by myself: invokeTerminal already use such a 
> configuration switch
> 
>     KConfigGroup confGroup( KGlobal::config(), "General" );
>     QString exec = confGroup.readPathEntry("TerminalApplication", 
> "konsole");
> 
> for invokeBrowser I suggest to define a 'UseInternalBrowser' flag, for 
> invokeMailer a 'UseInternalMailer' flag
> 

There is already a configuration switch for the browser, please don't add a new one...
krun.cpp:      d->m_externalBrowser = KConfigGroup(KGlobal::config(), "General").readEntry("BrowserApplication");

And the configuration for the mailer comes from emaildefaults, according to KToolInvocation::invokeMailer in the _x11.cpp file.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).