[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Glimpse in kdereview
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-03-30 20:59:40
Message-ID: 200803301459.40501.aseigo () kde ! org
[Download RAW message or body]


On Sunday 30 March 2008, Kåre Särs wrote:
> bool makeQImage(const QByteArray &data,
>                 int width, int height,
>                 int bytes_per_line,
>                 ImageFormat format,
>                 QImage &img);

cool. 

suggestion: return a QImage instead of taking one by reference, and set it to 
QImage() on failure. the return can easily check for img.isNull() .. makes 
for a slightly more natural feeling API?

anyways.. would be great to see just one new lib going in rather than two, 
though i really hate discarding people's work =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]