[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KFilePlacesModel : separate storage for custom items and
From:       Kevin Ottens <ervin () kde ! org>
Date:       2008-03-26 18:34:25
Message-ID: 200803261934.25945.ervin () kde ! org
[Download RAW message or body]


Le Sunday 16 March 2008, nf2 a écrit :
> The new approach keeps the ~/.kde4/share/apps/kfileplaces/bookmarks.xml
> as it was and synchronizes the custom items with
> .local/share/shortcuts.xbel. The Synchronization is done by the new
> class KFilePlacesSharedBookmarks.

It looks fine here. I'd only have one complaint about this one, it blindly 
copies the whole bookmark to .local/share/shortcuts.xbel, while it should 
probably avoid copying all the KFilePlacesModel specific metadata (like ID, 
isSystemItem, etc.). Could you try to tidy that up before committing?

Testing your patch I noticed that now the default places have wrong icons... 
Actually after reverting I still see this behavior, so I wonder if it could 
be related to your previous changes to KBookmark.

> The minor changes to KFilePlacesModel:
>
> * System items are tagged with a <isSystemItem>true</isSystemItem>.
> * I improved the ID-generator for more unique id's.

They look fine.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]