[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KBookmarks / fd.o desktop-bookmark-specHi
From:       nf2 <nf2 () scheinwelt ! at>
Date:       2008-03-16 17:32:37
Message-ID: 47DD59B5.6050700 () scheinwelt ! at
[Download RAW message or body]

Hi Daniel,

Daniel Teske wrote:
> Hi Norbert,
> 
> thanks for the patch. And sorry for taking so long to answer. As to the icon code, that looks good and \
> correct. For the external file part, I have a few questions: 
> In the new KBookmarkManager::KBookmarkManager() constructor, you only start watching if the file \
> already exists. Which if I read the code correctly means you never going to watch this file 
> Could you explain why you startWatch() in the destructor of KBookmarkmanager? That looks strange
> 

The startWatch() is also called in KBookmarkManager::saveAs(). It's not 
in the destructor - just looks like it in the patch :-)
The reason is that i was not sure whether i can start KDirWatch on a non 
existing file.

> In kbookmark.cc if we call the function findMetaData() with METADATA_KDE_OWNER, it returns the first \
> metadata element which has either the right or no owner. Which means if there are both, a metadata \
> element with METADATA_KDE_OWNER and a element with an empty owner, the function returns whichever comes \
> first. 

I think it works as expected, as only if ( owner == forOwner ) returns 
from the loop. But i have just moved this code and made it more generic.

Regards
Norbert


[prev in list] [next in list] [prev in thread] [next in thread]