[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: 'lightweight' QDir::isAbsolutePath replacement ?
From:       Thiago Macieira <thiago () kde ! org>
Date:       2008-03-14 11:18:44
Message-ID: 200803141218.44214.thiago () kde ! org
[Download RAW message or body]


On Friday 14 March 2008 11:33:53 Ralf Habacker wrote:
> Thiago Macieira schrieb:
> > On Friday 14 March 2008 10:35:12 Ralf Habacker wrote:
> >> Thiago Macieira schrieb:
> >>> Ralf Habacker wrote:
> >>>>> Here's the patch it will appear in tonight's snapshot. It can't be as
> >>>>> fast as Ralf's original code because there's at least one file engine
> >>>>> that is queried first (the resource file engine).
> >>>>
> >>>> Thanks for your efforts.
> >>>
> >>> Patch reverted because it broke all our Windows builds.
> >>>
> >>> I do not have more time to dedicate for this before 4.4.0 final.
> >>
> >> I would take some time to make it complete but how to validate the patch
> >> when the test app is not public available ?
> >
> > You can start by cleaning up your build and recompiling qmake and
> > src/tools (moc, uic, rcc). That's where it broke.
>
> I took the snapshot qt-all-opensource-src-4.4.0-snapshot-20080314 and
> tried to build it with msvc 2005 express version - moc, uic and rcc does
> not have any build problems.

This is the email I got from our developer:

=====
I've reverted the patch 301646, since it broke all Windows machines, 
even win32-g++.

qmake in release would crash violently, and debug build wouldn't 
output anyhing, since it would spin forever on a certain file, making 
the application crash due to no more stack space.
=====

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]