From kde-core-devel  Fri Mar 14 10:22:28 2008
From: Thiago Macieira <thiago () kde ! org>
Date: Fri, 14 Mar 2008 10:22:28 +0000
To: kde-core-devel
Subject: Re: 'lightweight' QDir::isAbsolutePath replacement ?
Message-Id: <200803141122.28585.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=120549019400919
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1506612.hUq4OhMsqT"

--nextPart1506612.hUq4OhMsqT
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 14 March 2008 10:54:13 Thiago Macieira wrote:
> On Friday 14 March 2008 10:35:12 Ralf Habacker wrote:
> > Thiago Macieira schrieb:
> > > Ralf Habacker wrote:
> > >>> Here's the patch it will appear in tonight's snapshot. It can't be =
as
> > >>> fast as Ralf's original code because there's at least one file engi=
ne
> > >>> that is queried first (the resource file engine).
> > >>
> > >> Thanks for your efforts.
> > >
> > > Patch reverted because it broke all our Windows builds.
> > >
> > > I do not have more time to dedicate for this before 4.4.0 final.
> >
> > I would take some time to make it complete but how to validate the patch
> > when the test app is not public available ?
>
> You can start by cleaning up your build and recompiling qmake and src/too=
ls
> (moc, uic, rcc). That's where it broke.

I have not found a testcase for isAbsolute, but it's easy to check whether=
=20
we're not breaking behaviour compatibility:

test a few real paths (relative and absolute)
test a few searchdir paths, with existing and non-existing files
test a few resource paths (those starting with :/)

=2D-=20
=C2=A0 Thiago Macieira =C2=A0- =C2=A0thiago (AT) macieira.info - thiago (AT=
) kde.org
=C2=A0 =C2=A0 PGP/GPG: 0x6EF45358; fingerprint:
=C2=A0 =C2=A0 E067 918B B660 DBD1 105C =C2=A0966C 33F5 F005 6EF4 5358

--nextPart1506612.hUq4OhMsqT
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (GNU/Linux)

iD8DBQBH2lHkM/XwBW70U1gRAtIvAJ0dFdY3DQKOXuaMKTMFYmLmU9WIBQCgn3bg
JqEwfQWYNlraVZx4VvNbHFA=
=L+Sf
-----END PGP SIGNATURE-----

--nextPart1506612.hUq4OhMsqT--