[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] KUniqueApplication: dbus service cleanup for Windows
From:       Jakob Petsovits <jpetso () gmx ! at>
Date:       2008-03-13 16:24:25
Message-ID: 200803131724.25576.jpetso () gmx ! at
[Download RAW message or body]

On Thursday, 13. March 2008, Rafael Fernández López wrote:
> Hi,
>
> > I'm not in a position to comment on your approach, but to avoid the code
> > looking at first sight like '==' has accidentally been written as '=', it
> > would read better as:
> >
> > +  if (QDBusConnection::sessionBus().isConnected()
> > +    && (dbusService = QDBusConnection::sessionBus().interface()) != 0)
>
> Nope, it is fine. It assigns to dbusService the address of the interface,
> and later checks if it was different to NULL. It is fine.

Which is exactly what David's modified version does as well, only explicitly 
(with a "!= 0" check instead of implicit conversion to boolean).

The "=" isn't replaced, it's still where it was before.

[prev in list] [next in list] [prev in thread] [next in thread]