--nextPart12852720.RyHCJpQ8Tz Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 11 March 2008 10:52:14 David Faure wrote: > On Saturday 08 March 2008, Thiago Macieira wrote: > > David Faure wrote: > > >> =A0No. The next best option is still patching Qt, even if TT doesn't > > >> give a damn about the patch. That's their problem, not ours, and > > >> there's no point in complicating our lives by adding a duplicate > > >> function in kdelibs. Qt-copy/patches is not only for patches TT like, > > >> it's also for patches they don't like. Why do you think Qt3-based > > >> qt-copy patches has so many so old patches? > > > > > >API additions are a big no-no though. > > > > We're talking about making an already-existing static function a lot > > faster. I think it qualifies. > > Ralf said > "The patch is appended. It adds > static bool QFileInfo::isAbsolute(const QString &path); > static bool QFileInfo::isRelative(const QString &path); > [...]" > > That's new API, which can't go into qt-copy only if TT doesn't want it, > otherwise KDE will never compile with official versions of Qt, that's what > I meant. But apparently you guys at TT are okay with this patch so this > isn't a problem, I was only replying to "qt-copy/patches is also for > patches TT doesn't like": not if they add API. That's because Ralf designed the patch like that. He didn't have to add new= =20 API. Anyways, I'm in the middle of testing the patch. Unfortunately, the QDir un= it=20 tests we have did not work on my machine, so I needed to fix them in order = to=20 get a baseline for comparison. =2D-=20 =A0 Thiago Macieira =A0- =A0thiago (AT) macieira.info - thiago (AT) kde.org =A0 =A0 PGP/GPG: 0x6EF45358; fingerprint: =A0 =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358 --nextPart12852720.RyHCJpQ8Tz Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) iD8DBQBH1mE+M/XwBW70U1gRAkxZAKCY2pHtx69KRPvwkArcV8LO04wogwCfbCZT i4dh+lG61jqO5R0ISZUMXHY= =3Yab -----END PGP SIGNATURE----- --nextPart12852720.RyHCJpQ8Tz--