[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Multiple licenses and KAboutData
From:       "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date:       2008-02-29 10:04:32
Message-ID: 200802291104.33442.kossebau () kde ! org
[Download RAW message or body]

Am Mittwoch, 27. Februar 2008, um 13:22 Uhr, schrieb Friedrich W. H. Kossebau:
> But this gives me trouble with KAboutData:
> KAboutData just allows to set one licence "setLicense (LicenseKey
> licenseKey)". Was this done on purpose?
>
> If not, please look at the attached
> patch "multipleLicensesWithKAboutData.patch" for KAboutData. It allows
> multiple licenses (should be binary and behaviour compatibel), e.g. by
> 	aboutData.addLicense( ... ).addLicenseText( ... ).addLicenseTextFile( ...
> ); It includes also a unit test (at least for the license aspect). Okay to
> commit?
>
> The other patch "multipleLicenseOnAboutDialog" is a first approach to
> integrate this with KAboutApplicationDialog. For every additional license
> simply another clickable label will be added. Okay to commit?

Silence = no objection = okay?

Will commit on sunday, when I return to this computer and noone objects in the 
meantime. Still I would be happy by at least one supportive "makes sense" or 
such, thanks. :)

Friedrich
[prev in list] [next in list] [prev in thread] [next in thread]